"Ron Rosenfeld" wrote
"N1234, expect visual runway 25, advise when you have atis Xray
and the airport in sight"

Why not just: "N5843Q, expect visual runway 32"?
It's shorter and conveys the same information and (implied) request.

It may be shorter, but we are required to know the other two items:
that you have the current weather (atis) and that you have the airport
in sight.

Even better is when the "visual" is on an ATIS, if available.

Can skip that info if pilot advises he has the ATIS, but since the
rule says the controller shall advise of the approach on initial
contact or as soon as possible thereafter, the pilot has to advise
of the ATIS on his initial contact. Most airports I do approaches
to dont have an ATIS, so it's a moot point.

See 7110.65 Par 4-7-10
http://www.faa.gov/atpubs/ATC/Chp4/atc0407.html#4-7-1

4-7-10. APPROACH INFORMATION

a. Both en route and terminal approach control sectors shall provide
current approach information to aircraft destined to airports for which they
provide approach control services. This information shall be provided on
initial contact or as soon as possible thereafter. Approach information
contained in the ATIS broadcast may be omitted if the pilot states the
appropriate ATIS code or items 3-5 below may be omitted for pilots destined
to uncontrolled airports when they advise receipt of the automated weather;
otherwise, issue approach information by including the following:

1. Approach clearance or type approach to be expected if two or more
approaches are published and the clearance limit does not indicate which
will be used.

2. Runway if different from that to which the instrument approach is
made.

3. Surface wind.

4. Ceiling and visibility if the reported ceiling at the airport of
intended landing is below 1,000 feet or below the highest circling minimum,
whichever is greater, or the visibility is less than 3 miles.

5. Altimeter setting for the airport of intended landing.


Chris